Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@npmcli/run-script@1.8.3 #2683

Closed
wants to merge 1 commit into from
Closed

@npmcli/run-script@1.8.3 #2683

wants to merge 1 commit into from

Conversation

ljharb
Copy link
Collaborator

@ljharb ljharb commented Feb 12, 2021

Extracted out of #2654.

@ljharb ljharb requested a review from a team as a code owner February 12, 2021 17:07
@ljharb ljharb mentioned this pull request Feb 12, 2021
Merged
@wraithgar
Copy link
Member

This is already queued up for v7.5.4 9a6e9d3

@wraithgar wraithgar closed this Feb 12, 2021
@ljharb
Copy link
Collaborator Author

ljharb commented Feb 12, 2021 •
edited

@wraithgar yes but it's not on latest, and thus #2654 won't pass without it landing here.

To be clear, this is a PR to latest, and so it does not matter what's in "a branch that's not latest"

@wraithgar
Copy link
Member

I'm going to make sure the tests pass in the release branch itself so we can get around this hiccup.

@ljharb
Copy link
Collaborator Author

ljharb commented Feb 12, 2021

I'm just really confused why something would be in the release branch that isn't in the default branch.

@ljharb ljharb deleted the run-script branch February 12, 2021 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ljharb @wraithgar