fix(runScript): obey silent loglevel #2719
Merged
+10
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is still a draft till the same changes can be made in pacote, libnpmpack, and libnpmversion. |
darcyclarke
added
semver:patch
wraithgar
added
the
release: next
|
All of the places where we're calling runScript outside of the cli code itself have been updated and are in the |
If the user has specified a silent loglevel, we should pass that intention on when we call runScript Also a small cleanup in lib/run-script.js so that the reference to @npmcli/run-script is named the same as other files. PR-URL: #2719 Credit: @wraithgar Close: #2719 Reviewed-by: @nlf
nlf
force-pushed
the
gar/silent-run-script
branch
from
0071184
to
b018eb8
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user has specified a silent loglevel, we should pass that intention on
when we call runScript
Also a small cleanup in lib/run-script.js so that the reference to
@npmcli/run-script is named the same as other files.