Use Actions for CI #272
Closed
Use Actions for CI #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 31, 2019
Merged
This was referenced Nov 14, 2019
This was referenced Nov 25, 2019
This was referenced Dec 5, 2019
This was referenced Dec 18, 2019
This was referenced Jan 17, 2020
This was referenced Feb 25, 2020
This was referenced Mar 14, 2020
This was referenced Mar 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What / Why
Hello! I was chatting with @mikemimik about using Actions for CI, so here's a spike for it. I've done my best to convert the
.travis.ymlfile over to a GitHub Actions'.github/workflows/ci.ymlfile.For the most part I was able to directly map everything that was being done in Travis except the Slack notification. If that's a blocker, we could perhaps create a separate Actions => Slack action that works with the id like Travis.
As for why - I saw that a Travis build was pending for around 40 minutes. That's my whole reasoning 馃榿
You can take a look at the timings here in this PRActions won't show the statuses on this PR because they ran on my fork - you can 馃憖 them here: https://github.com/JasonEtco/cli/actions.This workflow runs the full test suite against Node 8,10 and 12, and against Linux (
ubuntu-latest) and Windows.The Travis and Appveyor files can be removed, but I figured y'all can try this out before removing the others if you decide you want to.
Let me know if I can clarify anything 馃憤