Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fund subcommand #273

Closed
wants to merge 5 commits into from
Closed

Commits on Oct 30, 2019

  1. support: add support subcommand

    PR-URL: npm#246
    Credit: @kemitchell
    Close: npm#246
    Reviewed-by: @ruyadorno
    
    Thanks @kemitchell for providing the initial work that served as a base
    for `npm fund`, its original commits messages are preserved as such:
    
    - support: add support subcommand
    - support: fix request caching
    - support: further sanitize contributor data
    - doc: Fix typo
    - support: simplify to just collecting and showing URLs
    - install: improve `npm support` test
    - install: drop "the" before "projects you depend on"
    - doc: Reword mention of `npm support` in `package.json` spec
    kemitchell authored and ruyadorno committed Oct 30, 2019
    Copy the full SHA
    c757289 View commit details
    Browse the repository at this point in the history
  2. fund: add fund command

    This commit introduces the `npm fund` command that lists all `funding`
    info provided by the installed dependencies of a given project.
    
    Notes on implementation:
    
    - `lib/utils/funding.js` Provides helpers to validate funding info and
    return a tree-shaped structure containing the funding data for all deps.
    - `lib/fund.js` Implements `npm fund <pkg>` command
    - Added tests
      - `npm install` mention of funding
      - `npm fund <pkg>` variations
      - unit tests for added `lib/utils` and `lib/install` helpers
    - Added docs for `npm fund`, `funding` `package.json` property
    - Fixed `lib/utils/open-url` to support `--json` config
    - Documented `unicode` on `npm install` docs
    
    Refs: https://github.com/npm/rfcs/blob/2d2f00457ab19b3003eb6ac5ab3d250259fd5a81/accepted/0017-add-funding-support.md
    ruyadorno committed Oct 30, 2019
    Copy the full SHA
    24baa17 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2019

  1. fix tests

    ruyadorno committed Oct 31, 2019
    Copy the full SHA
    ebda4ca View commit details
    Browse the repository at this point in the history
  2. fix planned tap tests

    ruyadorno committed Oct 31, 2019
    Copy the full SHA
    2f9f22c View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    fd1856d View commit details
    Browse the repository at this point in the history