Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not print error banner for shell proxy commands #2742

Closed
wants to merge 1 commit into from

Commits on Feb 20, 2021

  1. Do not print error banner for shell proxy commands

    There are a few commands (exec, run-script, and the run-script proxies)
    where essentially npm is acting like a very fancy shell.  It is peculiar
    and noisy for npm to print a verbose error banner at the end of these
    commands, since presumably the command itself already did whatever it
    had to do to report the error appropriately.
    
    For example, `npm test` runs a test script, usually outputting test
    results.  Having npm then tell me that my tests failed with exit status
    1 and print a debug log, is unnecessary and unwanted.
    
    When the error encountered for these commands does not have a non-zero
    numeric 'code', then we still print the standard npm error reporting
    messages, because presumably something went wrong OTHER than a process
    exiting with a non-zero status code.
    isaacs committed Feb 20, 2021
    Copy the full SHA
    5287b6e View commit details
    Browse the repository at this point in the history