Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: enable mutating flat-options #2802

Closed
wants to merge 3 commits into from
Closed

chore: enable mutating flat-options #2802

wants to merge 3 commits into from

Commits on Feb 28, 2021

  1. fix(npm) pass npm context everywhere 

    Instead of files randomly requiring the npm singleton,
we pass it where it needs to go so that tests don't need
to do so much require mocking everywhere
    @wraithgar
    wraithgar committed Feb 28, 2021
    Copy the full SHA
    54feab6 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2021

  1. fix(npm.output): make output go through npm.output 

    All output that anything wants to make now goes through
`npm.output()`.  This is an incremental change getting us
closer to where we want to be with testing.
    @wraithgar
    wraithgar committed Mar 1, 2021
    Copy the full SHA
    8863fef View commit details
    Browse the repository at this point in the history

  2. chore: enable mutating flat-options 

    This will allow for changing configs that are read by commands through
flatOptions.

Based of npm#2795, land that first.

Relates to: npm#2765
Relates to: npm/rfcs#117
    @ruyadorno
    ruyadorno committed Mar 1, 2021
    Copy the full SHA
    52c4d3f View commit details
    Browse the repository at this point in the history