Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(repo, auth.sso): don't promisify open-url #2824

Merged
merged 1 commit into from Mar 4, 2021
Merged

fix(repo, auth.sso): don't promisify open-url #2824

merged 1 commit into from Mar 4, 2021

Commits on Mar 4, 2021

  1. fix(repo, auth.sso): don't promisify open-url 

    This causes a `cb() not called` error as the promisified
function explodes silently.

PR-URL: #2824
Credit: @wraithgar
Close: #2824
Reviewed-by: @ruyadorno
    @wraithgar @ruyadorno
    wraithgar authored and ruyadorno committed Mar 4, 2021
    Copy the full SHA
    9600664 View commit details
    Browse the repository at this point in the history