Release/v7.6.1 #2825
Merged
Release/v7.6.1 #2825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The lifecycle events section was very out of date, and lots of other cleanup needed to happen too PR-URL: #2690 Credit: @wraithgar Close: #2690 Reviewed-by: @ruyadorno
I checked cli's code with Typescript using the tsconfig below. The
compiler found a few arguments that are not used, so I removed them. In
the case of `npm whoami`, it is clearer that it ignores its `args`
and instead relies on `npm.flatOptions`.
```json
{
"compilerOptions": {
"moduleResolution": "node",
"module": "commonjs",
"resolveJsonModule": true,
"target": "es2019",
"noImplicitAny": false,
"noImplicitThis": true,
"strict": true,
"maxNodeModuleJsDepth": 0,
"noEmit": true,
"allowJs": true,
"checkJs": true,
"types": ["node"],
"lib": ["esnext"]
},
"include": ["lib"]
}
```
PR-URL: #2766
Credit: @sandersn
Close: #2766
Reviewed-by: @nlf, @ruyadorno, @Matausi29
Instead of files randomly requiring the npm singleton, we pass it where it needs to go so that tests don't need to do so much require mocking everywhere PR-URL: #2772 Credit: @wraithgar Close: #2772 Reviewed-by: @ruyadorno
1. Set the shebang to /usr/bin/env bash instead of /bin/sh (which might be dash or some other shell) 2. Use Unix-style line endings, not Windows-style (Cygwin accepts either, but mingw bash sometimes objects, and WSL bash always does) 3. Test against paths using wslpath if available, but still pass win32 paths to node.exe, since it is a Windows binary that only knows how to handle Windows paths. This makes npm as installed by the Node.js Windows MSI installer behave properly under WSL, Cygwin, MINGW Git Bash, and the internal MINGW Git Bash when posix CLI utilities are exposed to the cmd.exe shell. The test is not quite as comprehensive as I'd like. It runs on the various Windows bash implementations if they are found in their expected locations, skipping any that are not installed. Short of shipping mingw, cygwin, and wsl as test fixtures, I'm not sure how we could do much better, however. At least, we can use this test to assist debug and catch issues on Windows machines (ours or users who report problems). PR-URL: #2789 Credit: @isaacs Close: #2789 Reviewed-by: @nlf
The searchopts get parsed and added to the query elsewhere, they're not part of the `include` array they are an extra querystring that is added to the search request. PR-URL: #2803 Credit: @wraithgar Close: #2803 Reviewed-by: @ruyadorno
PR-URL: #2807 Credit: @kumavis Close: #2807 Reviewed-by: @ruyadorno
PR-URL: #2809 Credit: @BAJ- Close: #2809 Reviewed-by: @christoflemke, @sarin1234, @darcyclarke
pacote expects a **where** option that sets the cwd for all its operations, ref: https://github.com/npm/pacote#options This change properly sets that option in libnpmdiff options that will then properly forward it to pacote, this is specially important for when reading local file system specs. PR-URL: #2822 Credit: @ruyadorno Close: #2822 Reviewed-by: @wraithgar
This causes a `cb() not called` error as the promisified function explodes silently. PR-URL: #2824 Credit: @wraithgar Close: #2824 Reviewed-by: @ruyadorno
|
Shouldn't 3c9a589 be semver-minor? |
Wasn't so sure about it so I decided to go with a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v7.6.1 (2021-03-04)
BUG FIXES
3c9a589b0#2807npm explainshow when an edge is a bundled edge (@kumavis)b33c760ce#2766 unused arguments cleanup (@sandersn)4a5dd3a5a#2772 fix(npm) pass npm context everywhere (@wraithgar)e69be2ac5#2789 fix npm prefix on all Windows unix shells (@isaacs)2d682e4ca#2803 fix(search): don't pass unused args (@wraithgar)b3e7dd19b#2822 fix(diff): set option "where" for pacote (@ruyadorno)96006640b#2824 fix(repo, auth.sso): don't promisify open-url (@wraithgar)DOCUMENTATION
c8b73db82#2690 fix(docs): update scripts docs (@wraithgar)5d922394b#2809 update republish timeout after unpublish (@BAJ-)DEPENDENCIES
2d4ae598f@npmcli/arborist@2.2.6