Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support reporting on ERESOLVE errors when current is missing #3015

Merged
merged 1 commit into from Apr 1, 2021
Merged

Support reporting on ERESOLVE errors when current is missing #3015

merged 1 commit into from Apr 1, 2021

Commits on Apr 1, 2021

  1. Support reporting on ERESOLVE errors when current is missing 

    While it is somewhat helpful to get reports on this, since it indicates
an underlying problem in Arborist, it's also very disruptive and
unhelpful for users.  As of 2.3.0, Arborist gives us the currentEdge if
available, so we _can_ report on that at least.  If there is no node
_or_ edge, then we just don't say what the current state is, which isn't
useful, but at least is less annoying than a 'property of null'
exception.

PR-URL: #3015
Credit: @isaacs
Close: #3015
Reviewed-by: @wraithgar
    @isaacs @wraithgar
    isaacs authored and wraithgar committed Apr 1, 2021
    Copy the full SHA
    cb6eb0d View commit details
    Browse the repository at this point in the history