Commits on May 10, 2021

1. fix(packages): locale-agnostic string sorting …

   This adds the 'en' locale to all instances of String.localeCompare
   within the CLI codebase.
   
   Tests added for the cases where we're sorting arbitrary user-generated
   data.  The tests rely on the fact that 'ch' sorts after 'd' in the
   `'sk'` locale, but ahead of `'d'` in the `'en'` locale.  To ensure that
   this is the default behavior if no locale is specified, `LC_ALL=sk` is
   set in the test environment.
   
   Other instances of `localeCompare` sort data that the cli controls, so
   no tests were added.
   
   Re: #2829
   
   PR-URL: #3203
   Credit: @isaacs
   Close: #3203
   Reviewed-by: @ruyadorno

   

   isaacs authored and wraithgar committed May 10, 2021
   Copy the full SHA

   1d09214 View commit details

   Browse the repository at this point in the history