Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Drop stale Python 3<->node-gyp remark #3313

Closed
wants to merge 9 commits into from

Commits on May 24, 2021

  1. fix(docs): proper postinstall script file name

    I think this change was incorrect: npm#2024
    
    The point of this example is that the same script is being used for two different stages (`install` and `post-install`) so it would be a good idea to look at the `npm_lifecycle_event` environment variable inside this script to determine which stage is being run.
    
    PR-URL: npm#3282
    Credit: @KevinFCormier
    Close: npm#3282
    Reviewed-by: @wraithgar
    KevinFCormier authored and wraithgar committed May 24, 2021
    Copy the full SHA
    46a9bcb View commit details
    Browse the repository at this point in the history
  2. fix(ls): show relative paths from root

    Change the output in `npm ls` for symlink dependencies (including
    workspaces) to show the relative path from the project root, rather than
    the absolute path of the link target.
    
    This makes the output much less noisy and more ergonomic when many
    workspaces and link dependencies are in use, especially when paths are
    long.
    
    It is arguable that this output might be slightly misleading, since the
    _actual_ workspace symlink from `${root}/node_modules/b` to
    `${root}/packages/b` has a link value of `../packages/b`, not just
    `packages/b`.  (Or on Windows, always the full absolute path, because
    junctions.)  Thus, `npm ls b` will not show the same output as `ls -l
    node_modules/b`.
    
    However, `npm ls` shows the logical tree, not the physical tree, so
    presenting the user with a path that they can use and interpret is more
    important than presenting them with the strictly accurate details of
    their filesystem.
    
    PR-URL: npm#3272
    Credit: @isaacs
    Close: npm#3272
    Reviewed-by: @darcyclarke
    isaacs authored and wraithgar committed May 24, 2021
    Copy the full SHA
    83590d4 View commit details
    Browse the repository at this point in the history

Commits on May 26, 2021

  1. npm-audit-report@2.1.5

     * fix(exit-code): account for null auditLevel default (npm#46)
    wraithgar committed May 26, 2021
    Copy the full SHA
    dbbc151 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    a574b51 View commit details
    Browse the repository at this point in the history
  3. fix(docs): typo in package-lock.json docs

    PR-URL: npm#3307
    Credit: @rethab
    Close: npm#3307
    Reviewed-by: @wraithgar
    rethab authored and wraithgar committed May 26, 2021
    Copy the full SHA
    3c53d63 View commit details
    Browse the repository at this point in the history
  4. fix: set audit exit code properly

    When running 'npm audit', we properly exited correctly with the
    appropriate exitCode based on the audit level config and the report
    results.
    
    However, when going through the reifyFinish() function (as we do for
    'npm audit fix'), we were not setting that properly if the auditLevel
    was not set.
    
    Furthermore, if the auditLevel WAS set, we were setting the exit code to
    non-zero for *other* reify commands (install, update, etc.), where the
    audit information should be strictly advisory.
    
    When --json and --loglevel=silent were set, the exitCode was never being
    set properly.
    
    This fixes all these problems.
    
    PR-URL: npm#3311
    Credit: @isaacs
    Close: npm#3311
    Reviewed-by: @wraithgar
    isaacs authored and wraithgar committed May 26, 2021
    Copy the full SHA
    554e8a5 View commit details
    Browse the repository at this point in the history
  5. docs: rebuild npm-pack doc

    isaacs committed May 26, 2021
    Copy the full SHA
    96367f9 View commit details
    Browse the repository at this point in the history
  6. feat(link): add workspace support

    PR-URL: npm#3312
    Credit: @isaacs
    Close: npm#3312
    Reviewed-by: @wraithgar
    isaacs authored and wraithgar committed May 26, 2021
    Copy the full SHA
    399ff8c View commit details
    Browse the repository at this point in the history
  7. docs: Drop stale Python 3<->node-gyp remark

    PR-URL: npm#3313
    Credit: @spencerwilson
    Close: npm#3313
    Reviewed-by: @wraithgar
    spencerwilson authored and wraithgar committed May 26, 2021
    Copy the full SHA
    64b13dd View commit details
    Browse the repository at this point in the history