Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(libnpmexec): don't detach output from npm #3329

Merged
merged 1 commit into from May 28, 2021
Merged

fix(libnpmexec): don't detach output from npm #3329

merged 1 commit into from May 28, 2021

Commits on May 28, 2021

  1. fix(libnpmexec): don't detach output from npm 

    The npm output function refers to this.log.  libnpmexec has that passed
in, which decoupled the function from the npm object.  This fixes it,
and sets the tests up in a way where if the output function ever becomes
detached from this.npm in the same way, tests will fail.

PR-URL: #3329
Credit: @wraithgar
Close: #3329
Reviewed-by: @ruyadorno
    @wraithgar @ruyadorno
    wraithgar authored and ruyadorno committed May 28, 2021
    Copy the full SHA
    7b6db90 View commit details
    Browse the repository at this point in the history