Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tests): move more tests to use real npm #3463

Merged
merged 1 commit into from Jul 29, 2021
Merged

fix(tests): move more tests to use real npm #3463

merged 1 commit into from Jul 29, 2021

Commits on Jul 29, 2021

  1. fix(tests): move more tests to use real npm 

    This moves a handful of the smaller tests to using the new npm mock that
uses the real actual npm object.  It also extends the testing surface
area of a few tests back down into the actual `process.spawn` that
results, instead of anything internal to the code.

Some dead code in `lib/test.js` was found during this, as well as an
instance of a module throwing a string instead of an error object.

PR-URL: #3463
Credit: @wraithgar
Close: #3463
Reviewed-by: @nlf
    @wraithgar
    wraithgar committed Jul 29, 2021
    Copy the full SHA
    6a8086e View commit details
    Browse the repository at this point in the history