Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(config): consolidate use of npm.color #3563

Merged
merged 1 commit into from Jul 22, 2021
Merged

fix(config): consolidate use of npm.color #3563

merged 1 commit into from Jul 22, 2021

Commits on Jul 22, 2021

  1. fix(config): consolidate use of npm.color 

    The config value for `color` should never be directly read by npm, or
its submodules.  The derived value `npm.color` or
`npm.flatOptions.color` is what we want to use.

This PR consolidates the use of these values, makes sure there is only
one place the value is actually calculated, and stops relying on
duplicated code in the setup-log.js file for setting one of them.

PR-URL: #3563
Credit: @wraithgar
Close: #3563
Reviewed-by: @lukekarrys
    @wraithgar
    wraithgar committed Jul 22, 2021
    Copy the full SHA
    eb67054 View commit details
    Browse the repository at this point in the history