Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v7.20.4 #3613

Merged
merged 7 commits into from Aug 5, 2021
Merged

v7.20.4 #3613

merged 7 commits into from Aug 5, 2021

Conversation

wraithgar
Copy link
Member

v7.20.4 (2021-08-05)

BUG FIXES

DEPENDENCIES

  • 15fae4941 tar@6.1.6:
    • fix: properly handle top-level files when using strip
    • Avoid an unlikely but theoretically possible redos
    • WriteEntry backpressure
    • fix(unpack): always resume parsing after an entry error
    • fix(unpack): fix hang on large file on open() fail
    • fix: properly prefix hard links
  • 745326de0 libnpmexec@2.0.1:
    • Clear progress bar which overlays confirm prompt
  • e82bcd4e8 graceful-fs@4.2.7:
    • fix: start retrying immediately, stop after 10 attempts

This moves a handful of the smaller tests to using the new npm mock that
uses the real actual npm object.  It also extends the testing surface
area of a few tests back down into the actual `process.spawn` that
results, instead of anything internal to the code.

Some dead code in `lib/test.js` was found during this, as well as an
instance of a module throwing a string instead of an error object.

PR-URL: #3463
Credit: @wraithgar
Close: #3463
Reviewed-by: @nlf
  * fix: properly handle top-level files when using strip
  * Avoid an unlikely but theoretically possible redos
  * WriteEntry backpressure
  * fix(unpack): always resume parsing after an entry error
  * fix(unpack): fix hang on large file on open() fail
  * fix: properly prefix hard links
 * Clear progress bar which overlays confirm prompt
  * fix: start retrying immediately, stop after 10 attempts
@wraithgar wraithgar requested a review from a team as a code owner August 5, 2021 18:46
@wraithgar wraithgar merged commit 1aec805 into latest Aug 5, 2021
@ljharb
Copy link
Collaborator

ljharb commented Aug 5, 2021

test-only stuff seems like it shouldn't even really be in the changelog :-)

@wraithgar
Copy link
Member Author

test-only stuff seems like it shouldn't even really be in the changelog :-)

Dead code in lib/test.js was removed, as well as a tweak to throw an error object instead of a string. That's in the longer description of the PR/commit.

@ljharb
Copy link
Collaborator

ljharb commented Aug 5, 2021

ah, gotcha, that wasn't clear from the short description

@nlf nlf deleted the release/v7.20.4 branch March 28, 2022 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants