Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(config): user-agent properly shows ci #3754

Merged
merged 1 commit into from Sep 14, 2021
Merged

fix(config): user-agent properly shows ci #3754

merged 1 commit into from Sep 14, 2021

Commits on Sep 14, 2021

  1. fix(config): user-agent properly shows ci 

    The way we were flattening user-agent back into itself meant that any
values that were dependent on other config items would never be seen,
since we have to re-flatten the item for each one it depends on.

We also weren't re-flattening the user-agent when setting workspaces or
workspace, which were things that affected the final result.

This does change the main config value of `user-agent` but not the
flattened one.  We are not using the main config value anywhere (which
is correct).

PR-URL: #3754
Credit: @wraithgar
Close: #3754
Reviewed-by: @nlf
    @wraithgar
    wraithgar committed Sep 14, 2021
    Copy the full SHA
    b4aac34 View commit details
    Browse the repository at this point in the history