fix: --lockfile-version
to handle string number
#3900
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running "npm install --lockfile-version 3" fails with the error messages:
This is probably because all CLI input is handled as strings and
nopt
strictly comparing those strings to numbers without casting them to numbers. Replacing the[null, 1, 2, 3]
with[null, Number]
makesnopt
type cast and accept all numbers.With this change eg.
--lockfile-version 6
will still fail later on, so it won't open the flood gates for all version numbers. Will still fail with this later in the script:References
Related to #3880