Release/v8.1.2 #3957
Merged
Release/v8.1.2 #3957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As all CLI input is considered to be string, eg. a "npm install --lockfile-version 3" would fail with the error messages: ``` npm WARN invalid config lockfile-version="3" set in command line options npm WARN invalid config Must be one of: null, 1, 2, 3 ``` Until we have a config system that supports setting type and possible values of configs, we have to specify all string and number values for the `lockfile-version`, but we coerce all values to numbers in the flattener. Co-authored-by: @voxpelli Co-authored-by: @isaacs PR-URL: #3949 Credit: @lukekarrys Close: #3949 Reviewed-by: @isaacs
PR-URL: #3943 Credit: @wraithgar Close: #3943 Reviewed-by: @lukekarrys
PR-URL: #3953 Credit: @lukekarrys Close: #3953 Reviewed-by: @nlf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUG FIXES
cb9f43551#3949 allow--lockfile-versionconfig to be string and coerce to number (@lukekarrys)070901d7a#3943 fix(publish): clean args before logging (@wraithgar)DEPENDENCIES
8af94726b#3953arborist@4.0.338cee94#340 fix: set lockfileVersion from file during resetd310bd3#339 fix: always set originalLockfileVersion when doing shrinkwrap reset