Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor commands #3959

Merged
merged 1 commit into from Nov 3, 2021
Merged

chore: refactor commands #3959

merged 1 commit into from Nov 3, 2021

Commits on Nov 3, 2021

  1. chore: refactor commands

    This is the first phase of refactoring the internal structure of the npm
    commands to set us up for future changes.  This iteration changes the
    function signature of `exec` for all the commands to be a async (no more
    callbacks), and also groups all the commands into their own
    subdirectory.
    
    It also removes the Proxy `npm.commands` object, in favor of an
    `npm.cmd` and `npm.exec` function that breaks up the two things that
    proxy was doing. Namely, getting to the attributes of a given command
    (`npm.cmd` now does this), and actually running the command `npm.exec`
    does this.
    
    PR-URL: #3959
    Credit: @wraithgar
    Close: #3959
    Reviewed-by: @lukekarrys
    wraithgar committed Nov 3, 2021
    Copy the full SHA
    8ffeb71 View commit details
    Browse the repository at this point in the history