Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(help|edit): use npm.exec, use file:/// #3994

Merged
merged 1 commit into from Nov 4, 2021
Merged

fix(help|edit): use npm.exec, use file:/// #3994

merged 1 commit into from Nov 4, 2021

Commits on Nov 4, 2021

  1. fix(help|edit): use npm.exec, use file:/// 

    Windows no longer allows `file://`, but instead requires `file:///` for
local file urls.

Also after the command refactor things shifted and the tests didn't
catch that the help pages didn't work at all anymore, and that the
post-edit rebuild didn't work. This cleans up those two issues.

PR-URL: #3994
Credit: @wraithgar
Close: #3994
Reviewed-by: @lukekarrys
    @wraithgar
    wraithgar committed Nov 4, 2021
    Copy the full SHA
    1e9c31c View commit details
    Browse the repository at this point in the history