Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release/v8.1.4 #4066

Merged
merged 25 commits into from Nov 18, 2021
Merged

Release/v8.1.4 #4066

merged 25 commits into from Nov 18, 2021

Commits on Nov 4, 2021

  1. chore: update to latest eslint and linting rules 

    This brings us in line with the rest of the linting rules we are wanting
to use on the npm cli repos.

There were several hundred over-length lines and instead of editing them
all by hand I piped the failing file through `prettier` and back through
`eslint` just to save some time and energy.  This means there may be
some quirks in the linting those files have, but we can fix those if we
see them and they bother us.

Other than that there were about 50 lines that are legitimately
over-length, all are now explicitly overridden.  Many are tests that
could be snapshots.

PR-URL: #3995
Credit: @wraithgar
Close: #3995
Reviewed-by: @lukekarrys
    @wraithgar
    wraithgar committed Nov 4, 2021
    Copy the full SHA
    2256454 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2021

  1. chore: eslint@8.0.0 @npmcli/eslint-config@2.0.0 

    * Update to eslint@8 and and @npmcli/eslint-config@2.0.0
* Remove eslint-plugin-node.

Also remove an unused script that was failing linting.  We don't use the
update-dist-tags script anymore as part of our release process.

PR-URL: #4016
Credit: @wraithgar
Close: #4016
Reviewed-by: @lukekarrys
    @wraithgar
    wraithgar committed Nov 8, 2021
    Copy the full SHA
    203fedf View commit details
    Browse the repository at this point in the history

  2. docs: By default npm ignores .gitignore and .npmignore 

    PR-URL: #4009
Credit: @danielcobo
Close: #4009
Reviewed-by: @wraithgar
    @danielcobo @wraithgar
    danielcobo authored and wraithgar committed Nov 8, 2021
    Copy the full SHA
    2039184 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2021

  1. chore: refactor pack tests 

    Uses the real npm object and doesn't mock anything.

PR-URL: #4018
Credit: @wraithgar
Close: #4018
Reviewed-by: @lukekarrys
    @wraithgar
    wraithgar committed Nov 9, 2021
    Copy the full SHA
    b8d6089 View commit details
    Browse the repository at this point in the history

  2. fix: don't try to open file:/// urls 

    These are never valid in the contexts from which this lib is called.
Namely these are the bugs, docs, fund, help, and repo commands, and for
oauth logins.

PR-URL: #4025
Credit: @wraithgar
Close: #4025
Reviewed-by: @isaacs
    @wraithgar
    wraithgar committed Nov 9, 2021
    Copy the full SHA
    7887fb3 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2021

  1. fix: explicitly allow npm help to open file:/// man pages 

    PR-URL: #4026
Credit: @wraithgar
Close: #4026
Reviewed-by: @isaacs
    @wraithgar
    wraithgar committed Nov 10, 2021
    Copy the full SHA
    cd6d3a9 View commit details
    Browse the repository at this point in the history

  2. fix: clean up birthday command 

    Clean up tests too

PR-URL: #4033
Credit: @wraithgar
Close: #4033
Reviewed-by: @lukekarrys
    @wraithgar
    wraithgar committed Nov 10, 2021
    Copy the full SHA
    5cf6068 View commit details
    Browse the repository at this point in the history

  3. chore: clean up snapshots 

    Looks like tests were removed but the snapshots still have them.

PR-URL: #4019
Credit: @wraithgar
Close: #4019
Reviewed-by: @lukekarrys
    @wraithgar
    wraithgar committed Nov 10, 2021
    Copy the full SHA
    ac4f9e4 View commit details
    Browse the repository at this point in the history

  4. fix: command completion 

    The fake npm object in the tests wasn't returning an async function

Fixes: #4020

PR-URL: #4032
Credit: @wraithgar
Close: #4032
Reviewed-by: @lukekarrys
    @wraithgar
    wraithgar committed Nov 10, 2021
    Copy the full SHA
    72ca4a4 View commit details
    Browse the repository at this point in the history

  5. fix(install): command completion with single match 

    During a refactoring of the tests a bug was found in the install command
completion that would return nothing if there was a valid match, this
fixes that bug and also makes the tests actually test things.

PR-URL: #4023
Credit: @wraithgar
Close: #4023
Reviewed-by: @lukekarrys
    @wraithgar
    wraithgar committed Nov 10, 2021
    Copy the full SHA
    b789491 View commit details
    Browse the repository at this point in the history

  6. chore: switch to true static attributes 

    now that we're off of node10 we can clean this up

PR-URL: #3989
Credit: @wraithgar
Close: #3989
Reviewed-by: @lukekarrys
    @wraithgar
    wraithgar committed Nov 10, 2021
    Copy the full SHA
    ea352f5 View commit details
    Browse the repository at this point in the history

  7. chore: refactor audit tests 

    Use a real npm object, actually assert things

PR-URL: #4036
Credit: @wraithgar
Close: #4036
Reviewed-by: @lukekarrys
    @wraithgar
    wraithgar committed Nov 10, 2021
    Copy the full SHA
    201df17 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2021

  1. docs: turn off smart quotes, update doctype and charset 

     * When rendering HTML documentation, don't use smart quotes because they're icky and hard to copy/paste.
 * Add a <!DOCTYPE html> and a <meta charset="utf-8"> to be good HTML citizens.

PR-URL: #4046
Credit: @ethomson
Close: #4046
Reviewed-by: @wraithgar
    @wraithgar
    Edward Thomson authored and wraithgar committed Nov 15, 2021
    Copy the full SHA
    9868e7e View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2021

  1. docs: fix typo in npm install docs 

    PR-URL: #4053
Credit: @MansurAliKoroglu
Close: #4053
Reviewed-by: @wraithgar
    @MansurAliKoroglu @wraithgar
    MansurAliKoroglu authored and wraithgar committed Nov 17, 2021
    Copy the full SHA
    ea2906c View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2021

  1. separate github actions for workspaces 

    PR-URL: #4050
Credit: @fritzy
Close: #4050
Reviewed-by: @wraithgar

PR-URL: #4050
Credit: @fritzy
Close: #4050
Reviewed-by: @wraithgar
    @fritzy
    fritzy committed Nov 18, 2021
    Copy the full SHA
    44e39ce View commit details
    Browse the repository at this point in the history

  2. chore: more faithfully mock global.process in test 

    PR-URL: #4052
Credit: @isaacs
Close: #4052
Reviewed-by: @wraithgar
    @isaacs @fritzy
    isaacs authored and fritzy committed Nov 18, 2021
    Copy the full SHA
    654908f View commit details
    Browse the repository at this point in the history

  3. deps: signal-exit@3.0.6, tap@15.1.2

    @isaacs @fritzy
    isaacs authored and fritzy committed Nov 18, 2021
    Copy the full SHA
    7b4aa59 View commit details
    Browse the repository at this point in the history

  4. deps: npmlog@6.0.0 

    PR-URL: #4049
Credit: @wraithgar
Close: #4049
Reviewed-by: @fritzy
    @wraithgar @fritzy
    wraithgar authored and fritzy committed Nov 18, 2021
    Copy the full SHA
    0801585 View commit details
    Browse the repository at this point in the history

  5. chore(docs): jsdom@8.1.0 

    PR-URL: #4048
Credit: @wraithgar
Close: #4048
Reviewed-by: @fritzy
    @wraithgar @fritzy
    wraithgar authored and fritzy committed Nov 18, 2021
    Copy the full SHA
    ca59987 View commit details
    Browse the repository at this point in the history

  6. chore(docs): cmark-gfm@0.9.0

    @wraithgar @fritzy
    wraithgar authored and fritzy committed Nov 18, 2021
    Copy the full SHA
    4496ac4 View commit details
    Browse the repository at this point in the history

  7. deps: node-gyp@8.4.0 

     * feat: support vs2022
 * feat: build with config.gypi from node headers

PR-URL: #4045
Credit: @wraithgar
Close: #4045
Reviewed-by: @lukekarrys
    @wraithgar @fritzy
    wraithgar authored and fritzy committed Nov 18, 2021
    Copy the full SHA
    088c116 View commit details
    Browse the repository at this point in the history

  8. dep: @npmcli/arborist 4.0.5 

    PR-URL: #4065
Credit: @fritzy
Close: #4065
Reviewed-by: @lukekarrys
    @fritzy
    fritzy committed Nov 18, 2021
    Copy the full SHA
    44bfa37 View commit details
    Browse the repository at this point in the history

  9. docs: changelog for v8.1.4

    @fritzy
    fritzy committed Nov 18, 2021
    Copy the full SHA
    986e7c4 View commit details
    Browse the repository at this point in the history

  10. update AUTHORS

    @fritzy
    fritzy committed Nov 18, 2021
    Copy the full SHA
    e219397 View commit details
    Browse the repository at this point in the history

  11. 8.1.4

    @fritzy
    fritzy committed Nov 18, 2021
    Copy the full SHA
    940ba87 View commit details
    Browse the repository at this point in the history