Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(view): error on missing version #5035

Merged
merged 15 commits into from Jun 22, 2022
Merged

fix(view): error on missing version #5035

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
19e125e
Fixed bug in "npm show"
lukaskuhn-lku Jun 12, 2022
d8afc9f
Update lib/commands/view.js
lukaskuhn-lku Jun 13, 2022
ad11084
fixed linting errors
lukaskuhn-lku Jun 13, 2022
2abbd4d
added check if versions exist
lukaskuhn-lku Jun 13, 2022
66c4396
Merge branch 'latest' of https://github.com/lukaskuhn-lku/npm.cli int…
lukaskuhn-lku Jun 13, 2022
8653b05
changed to check for latest
lukaskuhn-lku Jun 13, 2022
39df374
Update lib/commands/view.js
lukaskuhn-lku Jun 13, 2022
10fadbc
Changed double quotes to singles
lukaskuhn-lku Jun 13, 2022
7674df2
Delete 2022-06-12T19_00_57_659Z-debug-0.log
lukaskuhn-lku Jun 13, 2022
6739ae7
Delete 2022-06-12T19_00_57_809Z-debug-0.log
lukaskuhn-lku Jun 13, 2022
3f42901
Delete package.json
lukaskuhn-lku Jun 13, 2022
6754d60
Delete package.json
lukaskuhn-lku Jun 13, 2022
367beb4
changed space for linting
lukaskuhn-lku Jun 13, 2022
9ee8be7
added test coverage for the bug fix
lukaskuhn-lku Jun 14, 2022
3f19aeb
fixup! added test coverage for the bug fix
wraithgar Jun 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 9 additions & 0 deletions lib/commands/view.js
View file
Open in desktop
Expand Up @@ -236,6 +236,15 @@ class View extends BaseCommand {
}
})

// No data has been pushed because no data is matching the specified version
if (data.length === 0 && version !== 'latest') {
fritzy marked this conversation as resolved.
Show resolved Hide resolved
const er = new Error(`No match found for version ${version}`)
er.statusCode = 404
er.code = 'E404'
er.pkgid = `${pckmnt._id}@${version}`
throw er
}

if (
!this.npm.config.get('json') &&
args.length === 1 &&
Expand Down
9 changes: 9 additions & 0 deletions test/lib/commands/view.js
View file
Open in desktop
Expand Up @@ -33,6 +33,7 @@ const packument = (nv, opts) => {
},
},
blue: {
_id: 'blue',
name: 'blue',
'dist-tags': {
latest: '1.0.0',
Expand Down Expand Up @@ -464,6 +465,14 @@ t.test('throws when unpublished', async t => {
)
})

t.test('throws when version not matched', async t => {
const { npm } = await loadMockNpm(t)
await t.rejects(
npm.exec('view', ['blue@2.0.0']),
{ code: 'E404', pkgid: 'blue@2.0.0', message: 'No match found for version 2.0.0' }
)
})

t.test('workspaces', async t => {
const prefixDir = {
'package.json': JSON.stringify({
Expand Down