Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(arborist): use the sourceReference root rather than the node root for overrides #5227

Merged
merged 1 commit into from Aug 1, 2022
Merged

fix(arborist): use the sourceReference root rather than the node root for overrides #5227

merged 1 commit into from Aug 1, 2022

Commits on Jul 28, 2022

  1. fix(arborist): use the sourceReference root rather than the node root… 

    … for overrides

when we examine override references, if we look at only `this.from.root.package` the root could actually be a virtual one. in order to ensure we resolve references from the real root, we instead need to look at `this.from.sourceReference.root.package` to get the correct value.

closes #4395
    @nlf
    nlf committed Jul 28, 2022
    Copy the full SHA
    d8cebc1 View commit details
    Browse the repository at this point in the history