Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix update-notifier using deprecated -g config #5300

Closed

Conversation

dhmmasson
Copy link

@dhmmasson dhmmasson commented Aug 11, 2022

The notification message reads Run npm install -g npm@8.17.0 to update! instead of Run npm install --location=global npm@8.17.0 to update!

I updated the command in the update-notifier to

const cmd = `npm install --location=global npm@${latest}`

References

Fixes #5299

The notification message reads `Run npm install -g npm@8.17.0 to update!` instead of `Run npm install --location=global npm@8.17.0 to update!`
@dhmmasson dhmmasson requested a review from a team as a code owner August 11, 2022 22:04
@ljharb
Copy link
Collaborator

ljharb commented Aug 11, 2022

It's supposed to say "-g" - that config is not actually deprecated, it was just one version (update: two versions) of npm that mistakenly indicated that.

@dhmmasson
Copy link
Author

My bad then... I tested with 8.11 and 8.12 and both displayed the warn...
Closing then.

@dhmmasson
Copy link
Author

already fixed with #4982.
Sorry

@dhmmasson dhmmasson closed this Aug 11, 2022
@dhmmasson dhmmasson deleted the fix-deprecated-update-notification branch August 11, 2022 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Use of deprecated -g option in update notification
2 participants