Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: @npmcli/fs@3.1.0 #5813

Merged
merged 2 commits into from Nov 8, 2022
Merged

deps: @npmcli/fs@3.1.0 #5813

merged 2 commits into from Nov 8, 2022

Conversation

lukekarrys
Copy link
Member

This also removes readdir-scoped-modules and @npmcli/fs since those
are now a part of @npmcli/fs

@npm-cli-bot
Copy link
Collaborator

npm-cli-bot commented Nov 4, 2022

no statistically significant performance changes detected

timing results
app-large clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 41.429 ±8.17 15.714 ±0.03 14.272 ±0.09 18.500 ±1.81 2.660 ±0.03 2.665 ±0.02 2.137 ±0.02 9.932 ±0.01 2.142 ±0.01 3.688 ±0.86
#5813 42.962 ±0.44 15.351 ±0.04 14.047 ±0.09 17.634 ±2.07 2.646 ±0.01 2.644 ±0.00 2.085 ±0.00 9.830 ±0.04 2.075 ±0.01 3.278 ±0.28
app-medium clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 26.768 ±0.97 12.345 ±0.01 11.085 ±0.02 12.212 ±0.71 2.410 ±0.01 2.439 ±0.02 2.187 ±0.03 7.574 ±0.07 2.053 ±0.01 2.884 ±0.07
#5813 25.117 ±0.13 11.961 ±0.08 10.762 ±0.09 11.473 ±0.23 2.415 ±0.04 2.413 ±0.01 2.084 ±0.01 7.534 ±0.01 1.965 ±0.00 2.786 ±0.10

Copy link
Member

@wraithgar wraithgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay

@wraithgar wraithgar self-requested a review November 7, 2022 14:56
Copy link
Member

@wraithgar wraithgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI should be green of course

@lukekarrys lukekarrys force-pushed the deps/npmcli-fs branch 2 times, most recently from 3117a36 to 6cf597a Compare November 7, 2022 21:36
This also removes `readdir-scoped-modules` and `@npmcli/fs` since those
are now a part of `@npmcli/fs`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants