chore: fix tests for node 19 #5891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
reviewed
Nov 23, 2022
| delete process.exitCode | ||
| process.exitCode = undefined |
There was a problem hiding this comment.
was this an intentional change in node? it may be worth filing an issue or commenting on the PR that made the change.
There was a problem hiding this comment.
you may be correct that this was unintentional. i found another breakage in related code. opened an issue here: nodejs/node#45683
wraithgar
approved these changes
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
node 19 appears to have made it so that we can't delete the
process.exitCodeproperty. overwriting it withundefinedwill have to do moving forward