Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: mention --otp flag when prompting for OTP #60

Merged
merged 1 commit into from Aug 29, 2018
Merged

Docs: mention --otp flag when prompting for OTP #60

merged 1 commit into from Aug 29, 2018

Conversation

bakkot
Copy link
Contributor

@bakkot bakkot commented Aug 26, 2018 •
edited

It's nice to surface this a little more.

Also, I tweaked the wording a bit, since I was surprised that npm publish said there was an error before it prompted for an OTP. Prompting for an OTP is not an error condition.

@bakkot bakkot requested a review from a team as a code owner August 26, 2018 06:41
zkat
zkat approved these changes Aug 29, 2018
View reviewed changes
Copy link
Contributor

@zkat zkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems good enough to me. Thanks!

@zkat zkat changed the base branch from latest to release-next August 29, 2018 18:37
@zkat zkat added the docs label Aug 29, 2018
@zkat zkat merged commit b1a8729 into npm:release-next Aug 29, 2018
@bakkot bakkot deleted the patch-1 branch August 29, 2018 18:53
zkat pushed a commit that referenced this pull request Dec 10, 2018
@bakkot @zkat
docs: mention --otp flag when prompting for OTP (#60)
cfbca9f 
PR-URL: #60
Credit: @bakkot
Reviewed-By: @zkat
@snyk-bot snyk-bot mentioned this pull request Feb 25, 2022
Open
@kevinjm39 kevinjm39 mentioned this pull request May 1, 2022
Open
@baby636 baby636 mentioned this pull request May 13, 2022
Open
@thebpc thebpc mentioned this pull request May 13, 2022
Open
@NOUIY NOUIY mentioned this pull request May 13, 2022
Open
@CALISOULB CALISOULB mentioned this pull request May 13, 2022
Open
@Bhanditz Bhanditz mentioned this pull request May 14, 2022
Open
@bumplzz69 bumplzz69 mentioned this pull request May 14, 2022
Open
@bumplzz69 bumplzz69 mentioned this pull request Sep 29, 2022
Open
@MrBrain295 MrBrain295 mentioned this pull request Oct 5, 2022
Open
This was referenced Oct 5, 2022
Open
Open
Open
This was referenced Jan 4, 2024
Merged
Open
This was referenced Jan 11, 2024
Open
Open
@Jircs1 Jircs1 mentioned this pull request Mar 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zkat zkat zkat approved these changes

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bakkot @zkat @ljharb