Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: only save package-lock when truly finished #6095

Merged
merged 2 commits into from Feb 1, 2023
Merged

fix: only save package-lock when truly finished #6095

merged 2 commits into from Feb 1, 2023

Commits on Jan 26, 2023

  1. chore: clean snapshot before code change

    @wraithgar
    wraithgar committed Jan 26, 2023
    Copy the full SHA
    2b6bea5 View commit details
    Browse the repository at this point in the history

  2. fix: only save package-lock when truly finished 

    When we update the trees, the edges are refreshed to correct their
specs.  If we have written the package-lock before this point, it will
be incorrect.

No new tests are needed as existing tests were snapshotted w/ the broken
behavior, and are fixed now showing this bugfix in action.
    @wraithgar
    wraithgar committed Jan 26, 2023
    Copy the full SHA
    e05f890 View commit details
    Browse the repository at this point in the history