chore: fixes nodejs tests #696
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixes ability to run tests using an arbitrary node bin - Fixes `make test-npm` in nodejs repo - Added `tap-snapshots` folder - Added required `.npmrc` root file Fixes npm/statusboard#45
ruyadorno
added
semver:patch
ljharb
reviewed
Jan 16, 2020
| @@ -7,7 +7,8 @@ var supportedNode = [ | |||
| {ver: '10', min: '10.0.0'}, | |||
| {ver: '11', min: '11.0.0'}, | |||
| {ver: '12', min: '12.0.0'}, | |||
| {ver: '13', min: '13.0.0'} | |||
| {ver: '13', min: '13.0.0'}, | |||
| {ver: '14', min: '14.0.0'} | |||
There was a problem hiding this comment.
thank you for doing this in advance :-)
could perhaps this logic be changed to use semver so that every new node version is always treated as supported unless explicitly marked as not?
There was a problem hiding this comment.
yeah, it's in our radar to change that for v7 👍
There was a problem hiding this comment.
it’d also be nice tho for the last 6.x build to not report that new nodes are unsupported forever :-)
There was a problem hiding this comment.
right, that's a good point! I agree 👍 that could be a good community contribution wink wink
There was a problem hiding this comment.
Filed #697 (i'll need some help)
This was referenced Feb 11, 2024
This was referenced Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make test-npmin nodejs repotap-snapshotsfolder (fixes snapshot-dependent tests).npmrcroot file (fixes broken config tests)Fixes npm/statusboard#45