Automatically audit dependency licenses #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kemitchell
force-pushed
the
licensee
branch
from
cbad84b
to
356e797
Compare
annunah
approved these changes
Sep 15, 2018
|
Here's the Travis CI log where the output starts: |
|
I believe this is ready to go. |
|
Lets try:) |
zkat
approved these changes
Nov 13, 2018
|
This is basically like having bumpers at a bowling alley. I trust y'all are checking licenses of deps as you bring them in, but this will help catch anything that slips past. |
zkat
pushed a commit
that referenced
this pull request
Dec 10, 2018
PR-URL: #70 Credit: @kemitchell Reviewed-By: @zkat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an npm script and Travis CI script line to check dependencies' licenses against a configured acceptable-license rule. I've also added dependencies that lack proper license metadata to a whitelist, after checking their terms by hand.
Please note that I've only whitelisted the current versions of dependencies without valid license metadata. If we bump those deps, and the new versions don't have valid metadata, either, the license check will fail until the new versions are added to the whitelist. There are only four of those deps at present.
cc @iarna