Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bash_completion.d dir found in /etc not /usr/local #72

Merged
merged 1 commit into from Nov 26, 2018

Conversation

RobertKielty
Copy link
Contributor

@RobertKielty RobertKielty commented Sep 24, 2018

I found this page useful for setting up npm command completion. Thank you npm-cli
documentation team.

This suggested change is based on my system which runs Ubuntu where
the completion directory path for bash is found in /etc/bash_completion.d and not /usr/local/etc/bash_completion.d

I dug around docs for this in The Bash Manual and on an old (sadly retired) Debian Admin Site An Introduction to Bash Completion which seemed supportive of the dir being in /etc but I do not have access to an OS X machine where I guess bash_completion.d could be in /usr/local/etc so I left it in.

I found this page useful for setting up npm command completion. Thank you npm 
documentation team.

This suggested changed is based on my system which runs Ubuntu where
the completion directory path for bash is found in 
/etc/bash_completion.d and not /usr/local/etc/bash_completion.d

I dug around docs for this in The Bash Manual 
https://www.gnu.org/software/bash/manual/bashref.html#Programmable-Completion 
and on some an old (sadly retired) Debian Admin Site
https://debian-administration.org/article/317/An_introduction_to_bash_completion_part_2

which seemed supportive of the dir being in /etc but I do not have access 
to an OS X machine where I guess bash_completion.d could be in /usr/local/etc 
so I left it in.
@RobertKielty RobertKielty requested a review from a team as a code owner September 24, 2018 09:32
Copy link
Contributor

@zkat zkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zkat zkat changed the base branch from latest to release-next November 13, 2018 14:59
@zkat zkat added semver:patch semver patch level for changes docs labels Nov 13, 2018
@zkat zkat merged commit 15da826 into npm:release-next Nov 26, 2018
@RobertKielty RobertKielty deleted the patch-1 branch November 30, 2018 10:42
zkat pushed a commit that referenced this pull request Dec 10, 2018
I found this page useful for setting up npm command completion. Thank you npm 
documentation team.

This suggested changed is based on my system which runs Ubuntu where
the completion directory path for bash is found in 
/etc/bash_completion.d and not /usr/local/etc/bash_completion.d

I dug around docs for this in The Bash Manual 
https://www.gnu.org/software/bash/manual/bashref.html#Programmable-Completion 
and on some an old (sadly retired) Debian Admin Site
https://debian-administration.org/article/317/An_introduction_to_bash_completion_part_2

which seemed supportive of the dir being in /etc but I do not have access 
to an OS X machine where I guess bash_completion.d could be in /usr/local/etc 
so I left it in.

PR-URL: #72
Credit: @RobertKielty
Reviewed-By: @zkat
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:patch semver patch level for changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants