fix(ci): rm workspace node_modules

[reggi]

Fixes #7226, an issue where the npm ci needs to remove node_modules within workspace directories.

[npm-cli-bot]

no statistically significant performance changes detected

timing results

app-large	clean	lock-only	cache-only	modules-only	no-lock	no-cache	no-modules	no-clean	show-version	run-script	cache-only peer-deps	no-clean audit
npm@latest	38.757 ±3.81	10.873 ±0.11	12.134 ±0.05	1.586 ±0.02	1.618 ±0.01	1.304 ±0.00	8.516 ±0.09	1.316 ±0.01	0.144 ±0.01	0.170 ±0.00	14.012 ±0.49	3.426 ±1.78
#7490	38.891 ±0.50	10.728 ±0.05	11.677 ±0.01	1.582 ±0.04	1.543 ±0.00	1.278 ±0.00	8.318 ±0.03	1.281 ±0.00	0.140 ±0.00	0.167 ±0.00	14.875 ±0.05	2.162 ±0.01

app-medium	clean	lock-only	cache-only	modules-only	no-lock	no-cache	no-modules	no-clean	show-version	run-script	cache-only peer-deps	no-clean audit
npm@latest	31.022 ±1.69	7.987 ±0.02	8.945 ±0.05	1.518 ±0.01	1.500 ±0.01	1.445 ±0.01	5.809 ±0.00	1.323 ±0.02	0.139 ±0.00	0.168 ±0.00	9.453 ±0.04	3.541 ±2.22
#7490	29.324 ±0.04	8.025 ±0.03	8.831 ±0.05	1.543 ±0.00	1.554 ±0.02	1.428 ±0.00	5.879 ±0.03	1.314 ±0.03	0.140 ±0.00	0.165 ±0.00	9.759 ±0.01	1.990 ±0.05

[lukekarrys]

CI extends ArboristWorkspaceCmd which will call this.setWorkspaces() and then this.exec(). So we can check if this.workspacePaths is set and use that instead of calling getWorkspaces directly. Also ArboristWorkspaceCmd will always set includeWorkspaceRoot: false so we need to explicitly include where.

We need to do this because you can run npm ci -w workspace-a and have it only install the deps for workspace-a but you can't guarantee that the root node_modules won't end up populated. So in fixing this bug we want to make sure that we only rm -rf the node_modules specified by the workspace config, plus the root.

[lukekarrys]

Suggested change

	return await Promise.all([...workspacePaths.values()].map(async modulePath => {
	return await Promise.all([...(this.workspacePaths || []), where]).map(async modulePath => {