Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify that --dry-run isn't available in older versions of npm publish #83

Merged
merged 1 commit into from Nov 26, 2018

Conversation

kjin
Copy link
Contributor

@kjin kjin commented Oct 19, 2018

Not sure when --dry-run was introduced, I assume it was introduced in npm 6 (correct me if I'm wrong). Anyway, hopefully this will prevent future developers from making the mistake of using it in npm 5 (like I did).

Not sure when `--dry-run` was introduced, I assume it was introduced in npm 6 (correct me if I'm wrong). Anyway, hopefully this will prevent future developers from making the mistake of using it in npm 5 (like I did).
@kjin kjin requested a review from a team as a code owner October 19, 2018 21:12
Copy link
Contributor

@zkat zkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is useful I think. Long-term we'll want to have a better "introduced in..." in the docs, tho.

@zkat
Copy link
Contributor

zkat commented Nov 13, 2018

cc @neverett because it's the whole "available since..." docs thing. But I'll take this PR anyway.

@zkat zkat added the docs label Nov 13, 2018
@zkat zkat changed the base branch from latest to release-next November 13, 2018 15:20
@zkat zkat merged commit a91a470 into npm:release-next Nov 26, 2018
zkat pushed a commit that referenced this pull request Dec 10, 2018
… publish (#83)

Not sure when `--dry-run` was introduced, I assume it was introduced in npm 6 (correct me if I'm wrong). Anyway, hopefully this will prevent future developers from making the mistake of using it in npm 5 (like I did).

PR-URL: #83
Credit: @kjin
Reviewed-By: @zkat
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants