Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Taking a crack at updating the scripts docs. #89

Closed
wants to merge 1 commit into from
Closed

docs: Taking a crack at updating the scripts docs. #89

wants to merge 1 commit into from

Conversation

seanhealy
Copy link
Contributor

After doing a bit of a dive into the scripts life cycle to setup a git install I thought I'd take a crack at breaking down the life cycle here. I did a really rough start to see what y'all thought before going through each one just to make sure it made sense.

My plan was to break the life cycle hooks for each command out as I have started here.

I was also thinking of explaining some of the configurable commands such as start and test.

Anyway, hopefully this makes some sort of sense. 馃槂

@seanhealy seanhealy requested a review from a team as a code owner October 30, 2018 00:11
@zkat zkat added docs labels Nov 13, 2018
@zkat
Copy link
Contributor

zkat commented Nov 13, 2018

cc @neverett for review

neverett
neverett reviewed Dec 5, 2018
View reviewed changes
Copy link
Contributor

@neverett neverett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few small bits of feedback, but otherwise this looks good to me.

doc/misc/npm-scripts.md Outdated Show resolved Hide resolved
doc/misc/npm-scripts.md Outdated Show resolved Hide resolved
doc/misc/npm-scripts.md Outdated Show resolved Hide resolved
doc/misc/npm-scripts.md Outdated Show resolved Hide resolved
doc/misc/npm-scripts.md Outdated Show resolved Hide resolved
@seanhealy
Copy link
Contributor Author

Thanks for the comments! I'll circle back to finish the other sections and make these changes as soon as I can. 馃槂

@settings settings bot removed docs labels Nov 5, 2019
@ruyadorno ruyadorno force-pushed the npm-scripts-docs branch 2 times, most recently from c7625f9 to 12a9513 Compare January 14, 2020 20:31
@ruyadorno ruyadorno added Release 6.x work is associated with a specific npm 6 release semver:patch semver patch level for changes labels Jan 14, 2020
@ruyadorno ruyadorno added this to the OSS - Sprint 2 milestone Jan 14, 2020
@seanhealy
Copy link
Contributor Author

Sorry, this totally fell off my radar but, I'm really stoked that y'all 've picked it back up! 馃嵒

@mikemimik mikemimik mentioned this pull request Jan 27, 2020
Closed
@mikemimik mikemimik self-assigned this Jan 27, 2020
@mikemimik
Copy link
Contributor

Note: will be moving this from Sprint 2 -> Sprint 3 and rolled into the next release.

@darcyclarke
Copy link
Contributor

Closed out by @mikemimik in #729

@gutwrinch gutwrinch mentioned this pull request Oct 20, 2023
Merged
@LadyK-21 LadyK-21 mentioned this pull request Nov 30, 2023
Open
@soloinovator soloinovator mentioned this pull request Nov 30, 2023
Open
@EMWickd EMWickd mentioned this pull request Nov 30, 2023
Open
@varmakarthik12 varmakarthik12 mentioned this pull request Nov 30, 2023
Open
@hojatA1 hojatA1 mentioned this pull request Dec 1, 2023
Open
@adamlaska adamlaska mentioned this pull request Dec 1, 2023
Open
@jackromo888 jackromo888 mentioned this pull request Dec 1, 2023
Open
@kingjay66 kingjay66 mentioned this pull request Dec 1, 2023
Open
@leonardoadame leonardoadame mentioned this pull request Dec 1, 2023
Open
@311821105 311821105 mentioned this pull request Feb 11, 2024
Open
@kevinjm39 kevinjm39 mentioned this pull request Feb 11, 2024
Open
@LadyK-21 LadyK-21 mentioned this pull request Feb 11, 2024
Open
@Mary12jo33 Mary12jo33 mentioned this pull request Feb 11, 2024
Open
@adamlaska adamlaska mentioned this pull request Feb 11, 2024
Open
@soloinovator soloinovator mentioned this pull request Feb 11, 2024
Open
@Billywildhig Billywildhig mentioned this pull request Feb 11, 2024
Open
@nicholaschoi168 nicholaschoi168 mentioned this pull request Feb 12, 2024
Open
@jackromo888 jackromo888 mentioned this pull request Feb 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neverett neverett neverett left review comments

Assignees

@ruyadorno ruyadorno

@mikemimik mikemimik

Labels
Release 6.x work is associated with a specific npm 6 release semver:patch semver patch level for changes
Projects
None yet
Milestone
OSS - Sprint 3
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@seanhealy @zkat @mikemimik @darcyclarke @neverett @ruyadorno