Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix quotes on windows cmd shims #42

Closed
wants to merge 1 commit into from

Conversation

connorjsmith
Copy link

Resolves #41 by only using quotes around the node executable when a non-local node binary is used.

@isaacs
Copy link
Contributor

isaacs commented Oct 8, 2019

Hi, I haven't forgotten about this, just running out of time for the 6.12 release, and didn't make it to giving this one the attention it needs.

We'll probably get it (or something like it, if there's issues) in 6.12.1. Sorry for the delay, and thanks for your patience :)

fengmk2 added a commit to cnpm/npminstall that referenced this pull request Dec 7, 2019
need to wait for npm/cmd-shim#42
to be merged and publish a new version.
fengmk2 added a commit to cnpm/npminstall that referenced this pull request Dec 7, 2019
need to wait for npm/cmd-shim#42
to be merged and publish a new version.

closes #316
@fengmk2
Copy link

fengmk2 commented Dec 7, 2019

+1

fengmk2 added a commit to cnpm/npminstall that referenced this pull request Dec 7, 2019
need to wait for npm/cmd-shim#42
to be merged and publish a new version.

closes #316
@connorjsmith
Copy link
Author

@isaacs any idea if we can get this in to the next release of npm?

@isaacs
Copy link
Contributor

isaacs commented Feb 5, 2021

First, this needs to be rebased onto the latest master branch.

But more importantly, won't this break if %prog% or %dp0 contain spaces or \ characters? Or am I reading it wrong?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Local node incorrectly resolved on Windows
3 participants