Fix quotes on windows cmd shims #42
Closed
+29
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, I haven't forgotten about this, just running out of time for the 6.12 release, and didn't make it to giving this one the attention it needs. We'll probably get it (or something like it, if there's issues) in 6.12.1. Sorry for the delay, and thanks for your patience :) |
fengmk2
added a commit
to cnpm/npminstall
that referenced
this pull request
Dec 7, 2019
need to wait for npm/cmd-shim#42 to be merged and publish a new version.
fengmk2
added a commit
to cnpm/npminstall
that referenced
this pull request
Dec 7, 2019
need to wait for npm/cmd-shim#42 to be merged and publish a new version. closes #316
|
+1 |
fengmk2
added a commit
to cnpm/npminstall
that referenced
this pull request
Dec 7, 2019
need to wait for npm/cmd-shim#42 to be merged and publish a new version. closes #316
|
@isaacs any idea if we can get this in to the next release of npm? |
|
First, this needs to be rebased onto the latest master branch. But more importantly, won't this break if |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #41 by only using quotes around the node executable when a non-local node binary is used.