Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix arguments with parenthesis causing an error on Windows #26

Closed
wants to merge 1 commit into from
Closed

Fix arguments with parenthesis causing an error on Windows #26

wants to merge 1 commit into from

Commits on Jan 20, 2018

  1. Fix arguments with parenthesis causing an error on Windows 

    Because %* is expanded before anything, any arguments with parenthesis will make the .cmd fail with the following message:
\"" was unexpected at this time

This might actually be a security vulnerability because with the rightly crafted arguments, one would possibly execute arbirtrary commands,
even if the arguments were properly escaped.
Read https://gist.github.com/satazor/4e21543e5cd380032c2b6b38c3700223 for a more detailed explanation.

To solve this, %* was moved out of the condition.
    @satazor
    satazor committed Jan 20, 2018
    Copy the full SHA
    91354f3 View commit details
    Browse the repository at this point in the history