This repository has been archived by the owner on Nov 3, 2022. It is now read-only.
[WIP] feat: Add ability to deprecate singular config values #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jumoel
force-pushed
the
jumoel/deprecate-singular-config-values
branch
2 times, most recently
from
65af934
to
77e4d70
Compare
jumoel
force-pushed
the
jumoel/deprecate-singular-config-values
branch
from
77e4d70
to
b619bc8
Compare
jumoel
commented
Jul 1, 2022
| @@ -507,7 +511,13 @@ class Config { | |||
|
|
|||
| [_checkDeprecated] (key, where, obj, kv) { | |||
| // XXX(npm9+) make this throw an error | |||
| if (this.deprecated[key]) { | |||
| const value = obj[key] | |||
| const hasDeprecatedValues = Array.isArray(this.deprecatedValues[key]) | |||
There was a problem hiding this comment.
Should deprecatedValues perhaps be a function instead, to make it more generic and work on arbitrary types like Number?
|
Superseded by npm/cli#5149 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add the ability to deprecate single values for options, instead of just whole options.
Allows definitions to have a
deprecatedValuesarray, that lists the values that are deprecated.Why
Allows for instance the
--auth-typeconfiguration option to have non-deprecated as well as deprecated values.References
auth-typeconfig values cli#5115