Skip to content
This repository has been archived by the owner on Aug 11, 2021. It is now read-only.

remove socket error handler after request is done #142

Closed
wants to merge 2 commits into from
Closed

remove socket error handler after request is done #142

wants to merge 2 commits into from

Commits on Aug 29, 2016

  1. remove socket error handler after request is done 

    `npm-registry-client` uses `request`, which in turn uses an HTTP agent
for reusing sockets, so the `error` handlers registered on it in
`npm-registry-client` just piled up and kept being attached over the
entire lifetime of the socket.

This patch seeks to fix this by removing the listener from the socket
once the callback is invoked, as keeping it around after that would
just be a memory leak.
    @addaleax
    addaleax committed Aug 29, 2016
    Configuration menu
    Copy the full SHA
    ad42070 View commit details
    Browse the repository at this point in the history

  2. ci: add Node.js v4 and v6 to Travis matrix

    @addaleax
    addaleax committed Aug 29, 2016
    Configuration menu
    Copy the full SHA
    dde0eb7 View commit details
    Browse the repository at this point in the history