Skip to content
This repository has been archived by the owner on Aug 11, 2022. It is now read-only.

get correct resolved/version for remote packages #18799

Closed
wants to merge 1 commit into from
Closed

get correct resolved/version for remote packages #18799

wants to merge 1 commit into from

Conversation

joshclow
Copy link
Contributor

@joshclow joshclow commented Oct 12, 2017

When shrinkwrapping a remote dependency, use the package's version instead of resolved in getChildVersion (because resolved will be the URL to the package which semver will be very unhappy about later)
Additionally, grab the resolved value from a remote dependency as would be done for a registry dependency.

Resolves #17858

@joshclow joshclow requested a review from a team as a code owner October 12, 2017 05:28
@iarna
Copy link
Contributor

iarna commented Oct 13, 2017

Hey, thanks for digging into this!

Per the spec, this should be the tarball URL: https://github.com/npm/npm/blob/latest/doc/spec/package-lock.md#version-changed

I've commented over in #17858 but there are two different bugs at play here. Fixing the crash-on-http-in-version field is the top priority, followed by improving the "generate a package-lock from an existing node_modules" path to add these as registry, not remote, dependencies.

@iarna iarna closed this Oct 13, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot read property '0' of undefined
2 participants