feat: add verifyAttestations to registry.manifest #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wraithgar
reviewed
Feb 8, 2023
feelepxyz
changed the title
feelepxyz
changed the title
feelepxyz
commented
Feb 8, 2023
feelepxyz
commented
Feb 8, 2023
bdehamer
reviewed
Feb 9, 2023
wraithgar
reviewed
Feb 9, 2023
wraithgar
reviewed
Feb 9, 2023
wraithgar
reviewed
Feb 9, 2023
Adding sigstore-js for `audit signatures`. Related: #259 Signed-off-by: Philip Harrison <philip@mailharrison.com>
Add support for verifying sigstore attestations when fetching the registry.manifest. This will be ased in CLI as part of `audit signatures`. RFC: npm/rfcs#626 Signed-off-by: Philip Harrison <philip@mailharrison.com> Co-authored-by: Brian DeHamer <bdehamer@github.com> Signed-off-by: Philip Harrison <philip@mailharrison.com>
wraithgar
pushed a commit
that referenced
this pull request
Feb 13, 2023
Adding sigstore-js for `audit signatures`. Related: #259 Signed-off-by: Philip Harrison <philip@mailharrison.com>
Merged
wraithgar
pushed a commit
to npm/cli
that referenced
this pull request
Feb 14, 2023
Update `audit signatures` to also verify Sigstore attestations. Additional changes: - Adding error message to json error output as there are a lot of different failure cases with signature verification that would be hard to debug without this - Adding predicateType to json error output for attestations to diffentiate between provenance and publish attestations References: - Pacote changes: npm/pacote#259 - RFC: npm/rfcs#626 Signed-off-by: Philip Harrison <philip@mailharrison.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for verifying sigstore attestations when fetching the registry.manifest. This will be ased in CLI as part of
audit signatures.Note: not the prettiest codes here yet as I've focused on just trying to cover all the corner cases and have tests to match.
RFC: npm/rfcs#626
Signed-off-by: Philip Harrison philip@mailharrison.com