fix: use ops+robot as git user for all ci #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the intention was to separate the registry team's automated actions from the cli team's. @darcyclarke may have more context there. |
|
We also have https://github.com/npm-deploy-user that is used to deploy the statusboard (maybe more?). The only thing I want from this is for the user that creates commits in the cli to have a GitHub profile like the others. So if we want to keep them separate that can still be accomplished. |
|
Moving it in this direction is probably still the right choice. Separating them out can be a future concern. |
wraithgar
approved these changes
Apr 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if we want to do this, or if there was a reason to keep these bot users separate.
This would change the git user of all our CI commits to @npm-robot. This is the user we use to create PRs to
nodejs/node(nodejs/node#42550) and add benchmark comments (npm/cli#4716 (comment)).