Use fs.rename instead of fs.renameSync #29
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fs.renameSync does not have the workarounds added by graceful-fs, and this causes issue in Windows. [See the polyfill in graceful-fs for more info.](https://github.com/isaacs/node-graceful-fs/blob/master/polyfills.js#L94). This should fix npm#104 and any outstanding EACCES and EPERM on Windows for all packages that uses write-file-atomic as dependency.
|
So, using asynchronous rename in synchronous write obviously doesn't work. Closing this in favor of isaacs/node-graceful-fs#119 that implements fs.renameSync workaround for win32 similar of that to fs.rename but blocking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fs.renameSync does not have the workarounds added by graceful-fs, and this causes issue in Windows. See the polyfill in graceful-fs for more info.
This should fix #28, jestjs/jest#4444 and any outstanding EACCES and EPERM on Windows for all packages that uses write-file-atomic as dependency.