Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use fs.rename instead of fs.renameSync #29

Closed
wants to merge 2 commits into from
Closed

Use fs.rename instead of fs.renameSync #29

wants to merge 2 commits into from

Commits on Oct 10, 2017

  1. Use fs.rename instead of fs.renameSync 

    fs.renameSync does not have the workarounds added by graceful-fs, and this causes issue in Windows. [See the polyfill in graceful-fs for more info.](https://github.com/isaacs/node-graceful-fs/blob/master/polyfills.js#L94).

This should fix npm#104 and any outstanding EACCES and EPERM on Windows for all packages that uses write-file-atomic as dependency.
    @mekwall
    mekwall committed Oct 10, 2017
    Configuration menu
    Copy the full SHA
    692a64b View commit details
    Browse the repository at this point in the history

  2. Throw error on rename failure

    @mekwall
    mekwall committed Oct 10, 2017
    Configuration menu
    Copy the full SHA
    4e4ece9 View commit details
    Browse the repository at this point in the history