Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/openapi ci #1182

Open
wants to merge 7 commits into
base: release50
Choose a base branch
from
Open

Chore/openapi ci #1182

wants to merge 7 commits into from

Conversation

mint-dewit
Copy link
Member

Type of Contribution

This is a:
CI Improvement

New Behavior

An OpenAPI client library will be published to NPM in tandem with our other libraries.

@mint-dewit mint-dewit requested a review from a team May 1, 2024 12:40
Copy link

codecov bot commented May 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.02%. Comparing base (b6256cc) to head (5b87e18).
Report is 3 commits behind head on release50.

Additional details and impacted files
@@             Coverage Diff             @@
##           release50    #1182    +/-   ##
===========================================
  Coverage      58.02%   58.02%            
===========================================
  Files            480      480            
  Lines          79065    79065            
  Branches        3673     4130   +457     
===========================================
+ Hits           45877    45879     +2     
+ Misses         33182    33162    -20     
- Partials           6       24    +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Julusian Julusian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind this using an action, but it might be better to do the needed yarn calls instead, seeing as it is fairly simple to do?

openapi-generation:
name: OpenAPI Generation
runs-on: ubuntu-latest
continue-on-error: true
timeout-minutes: 15
steps:
- uses: actions/checkout@v4
with:
persist-credentials: false
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version-file: ".node-version"
- name: Prepare Environment
run: |
cd packages
yarn
env:
CI: true
- name: Run generator
run: |
cd packages/openapi
yarn gendocs
yarn genserver
yarn genclient:ts
env:
CI: true

Perhaps that ci step should be backported to r50 too? I don't mind though, we shouldn't be making any notable changes to the api at this stage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants