Add sourcelayer "studio screen" (SOFIE-3132)

[nytamin]

About the Contributor

This pull request is posted on behalf of the NRK.

Type of Contribution

This is a:

Feature

Current Behavior

Graphics that are intended for backscreens in the studio have been put on the GRAPHICS layer (which is used for fullscreen gfx). However there is a need to distinguish the back screen graphcs from lower-thirds and fullscreen gfx.

New Behavior

A new SourceLayer "STUDIO_SCREEN" has been added, intended to be used for content targeting studio screens.

Testing

• I have added one or more unit tests for this PR
• I have updated the relevant unit tests
• No unit test changes are needed for this PR

Affected areas

This PR affects the GUI / display of Pieces.

Time Frame

No rush, but we're aiming at merging this into R51 within a week.

Other Information

Status

• PR is ready to be reviewed.
• The functionality has been tested by the author.
• Relevant unit tests has been added / updated.
• Relevant documentation (code comments, system documentation) has been added / updated.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 58.10%. Comparing base (d1a593c) to head (f51bbbf).
Report is 387 commits behind head on release51.

Files	Patch %	Lines
meteor/server/api/rest/v1/typeConversion.ts	0.00%	6 Missing ⚠️
...artThumbnail/Renderers/ThumbnailRendererFactory.ts	0.00%	1 Missing ⚠️
...r/client/ui/Shelf/Renderers/ItemRendererFactory.ts	0.00%	1 Missing ⚠️
meteor/lib/api/rest.ts	0.00%	1 Missing ⚠️

Additional details and impacted files

@@              Coverage Diff              @@
##           release51    #1189      +/-   ##
=============================================
- Coverage      58.10%   58.10%   -0.01%     
=============================================
  Files            483      483              
  Lines          79442    79451       +9     
  Branches        4000     3548     -452     
=============================================
+ Hits           46162    46166       +4     
- Misses         33255    33280      +25     
+ Partials          25        5      -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Julusian]

Should the new type be included in any of the following locations too?

• sofie-core/meteor/client/ui/PieceIcons/PieceCountdown.tsx

  Line 25 in dab4ff9

  const supportedLayers = new Set([

• sofie-core/meteor/client/ui/PieceIcons/PieceIcon.tsx

  Line 42 in dab4ff9

  switch (props.sourceLayer.type) {

• sofie-core/meteor/client/ui/PieceIcons/PieceIcon.tsx

  Line 88 in dab4ff9

  export const pieceIconSupportedLayers = new Set([

• sofie-core/meteor/client/ui/SegmentContainer/PieceMultistepChevron.tsx

  Line 15 in dab4ff9

  (piece.sourceLayer?.type === SourceLayerType.GRAPHICS || piece.sourceLayer?.type === SourceLayerType.LOWER_THIRD) &&

I'm honestly not sure if it should, I don't know what the PieceIcons stuff is for or where they are used. The PieceMultistepChevron one will be wanted though.