Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: input gateway devices lose rundown actions on reset SOFIE-3134 #1190

Merged
merged 1 commit into from
May 24, 2024

Conversation

Julusian
Copy link
Member

About the Contributor

This pull request is posted on behalf of the NRK.

Type of Contribution

This is a: Bug fix

Current Behavior

When using a streamdeck through the input gateway, when resetting the rundown any rundown based actions on the streamdeck will go blank and will no longer work.

They would return upon deactivating and reactivating the rundown, or restarting sofie.

This was due to a value being used non-reactively, causing incorrect invalidations when resetting the rundown.

Testing

  • I have added one or more unit tests for this PR
  • I have updated the relevant unit tests
  • No unit test changes are needed for this PR

Affected areas

This PR affects the input gateway

Time Frame

Other Information

Status

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

@Julusian Julusian requested a review from a team as a code owner May 16, 2024 13:10
Copy link

codecov bot commented May 16, 2024

Codecov Report

Attention: Patch coverage is 63.63636% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 58.11%. Comparing base (d1a593c) to head (12f8039).

Files Patch % Lines
...erver/api/deviceTriggers/RundownContentObserver.ts 20.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           release50    #1190    +/-   ##
===========================================
  Coverage      58.10%   58.11%            
===========================================
  Files            483      483            
  Lines          79442    79431    -11     
  Branches        4000     3556   -444     
===========================================
+ Hits           46162    46163     +1     
- Misses         33255    33263     +8     
+ Partials          25        5    -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Julusian Julusian merged commit aa69e5d into release50 May 24, 2024
70 checks passed
@Julusian Julusian deleted the fix/input-gateway-blank-on-reset-rundown branch May 24, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants