Rework Settings gui (SOFIE-2300) #922
Conversation
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## release50 #922 +/- ##
=============================================
- Coverage 57.09% 55.47% -1.62%
=============================================
Files 481 493 +12
Lines 76054 79050 +2996
Branches 3771 3832 +61
=============================================
+ Hits 43421 43855 +434
- Misses 32582 35144 +2562
Partials 51 51
☔ View full report in Codecov by Sentry. |
| type: GUISettingsType.SETTING, | ||
| name: t('Compatible Show Styles'), | ||
| description: t('Which Show Styles are compatible with this studio'), | ||
| id: `${urlBase}/blueprint`, |
There was a problem hiding this comment.
It would be really good if these ID's were autogenerated somehow? I think these will be very easy to get mixed up.
| type: GUISettingsType.SETTING, | ||
| name: t('Enable "Play from Anywhere"'), | ||
| description: t('When enabled, the "play from anywhere" option is available to the users in rundown-GUI'), | ||
| id: `${urlBase}/settings.enablePlayFromAnywhere`, | ||
| // getWarning: () => undefined, | ||
| render: () => { | ||
| return <EditAttribute {...editAttributeProps} type="checkbox" attribute="settings.enablePlayFromAnywhere" /> | ||
| }, | ||
| getSearchString: '', |
There was a problem hiding this comment.
These are very repetitive for a lot of these items. Should type: GUISettingsType.SETTING be implied, if not specified? Can the render function have a default implementation that can be overloaded, if needed?
| options={availableShowStyleBases} | ||
| label={t('Click to show available Show Styles')} | ||
| /> | ||
| {renderShowStyleEditButtons(studio, availableShowStyleBases)} |
There was a problem hiding this comment.
I think this could easily be a JSX component.
# Conflicts: # meteor/client/ui/Settings/SettingsMenu.tsx # meteor/client/ui/Settings/Studio/Devices/SelectDevices.tsx # meteor/server/collections/collection.ts
Work in progress
This PR aims at change how the settings pages are made, in order to provide several quality-of-life issues, such as: