Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implemented eslint problem matcher #2027

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

work933k
Copy link

I propose to have NX-console-extension to support the VSCode problemmatcher functionality for eslint-tasks.

@work933k work933k changed the title Implemented eslint problem matcher feat: Implemented eslint problem matcher Feb 20, 2024
@MaxKless MaxKless self-requested a review February 26, 2024 11:42
@MaxKless
Copy link
Collaborator

Thanks so much for submitting this PR! I'll look into it and give it a try :)

Copy link

nx-cloud bot commented Feb 26, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit b66c7ea. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 4 targets

Sent with 💌 from NxCloud.

Copy link
Collaborator

@MaxKless MaxKless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! It works great when running tasks from the project view.
However, there's additional places we should consider:

  • using the Nx: run and Nx: run target commands should also populate the problems pane
  • running the target from the tooltip in the integrated graph & project details view should also populate the problems pane
  • running the target from the Generate & Run Target view should also populate the problems pane

I think the easiest solution here is to check for the problemMatchers right inside CliTaskProvider.executeTask. You can use the positional argument when command === run, split it by : and check if it's a lint target. In that case, pass the problem matchers to the task.

Thanks a lot for this contribution it rocks!

P.S. also make sure to format your code with npx nx format --fix to make sure it passes CI :)

@MaxKless MaxKless force-pushed the master branch 2 times, most recently from 629dc4b to ec50b72 Compare February 28, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants