fix(devkit): don't replace begining undescore when creating file (#9870)

Underscore is a character usually used for sorting purposes and is absolutely legit. There is no reason to replace it. ISSUES CLOSED: #8875
nrwl · Apr 29, 2022 · 0bd08cc · 0bd08cc · vercel · Apr 29, 2022
1 parent bef8240
commit 0bd08cc
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/packages/devkit/src/utils/names.spec.ts b/packages/devkit/src/utils/names.spec.ts
@@ -8,6 +8,8 @@ describe('names', () => {
     expect(names('[fooBar]').className).toEqual('FooBar');
     expect(names('[...fooBar]').className).toEqual('FooBar');
     expect(names('foo-@bar').className).toEqual('FooBar');
+    expect(names(' foo bar').className).toEqual('FooBar');
+    expect(names('_foo_bar').className).toEqual('FooBar');
   });
 
   it('should support property names', () => {
@@ -17,6 +19,8 @@ describe('names', () => {
     expect(names('[fooBar]').propertyName).toEqual('fooBar');
     expect(names('[...fooBar]').propertyName).toEqual('fooBar');
     expect(names('foo-@bar').propertyName).toEqual('fooBar');
+    expect(names(' foo bar').propertyName).toEqual('fooBar');
+    expect(names('_foo_bar').propertyName).toEqual('fooBar');
   });
 
   it('should support file names', () => {
@@ -26,5 +30,7 @@ describe('names', () => {
     expect(names('[fooBar]').fileName).toEqual('[foo-bar]');
     expect(names('[...fooBar]').fileName).toEqual('[...foo-bar]');
     expect(names('foo-@bar').fileName).toEqual('foo-@bar');
+    expect(names(' foo bar').fileName).toEqual('-foo-bar');
+    expect(names('_foo_bar').fileName).toEqual('_foo-bar');
   });
 });
diff --git a/packages/devkit/src/utils/names.ts b/packages/devkit/src/utils/names.ts
@@ -58,7 +58,7 @@ function toFileName(s: string): string {
   return s
     .replace(/([a-z\d])([A-Z])/g, '$1_$2')
     .toLowerCase()
-    .replace(/[ _]/g, '-');
+    .replace(/(?!^[_])[ _]/g, '-');
 }
 
 /**