fix(storybook): ignore addon-notes from version update (#10568)

ISSUES CLOSED: #10484
nrwl · Jun 3, 2022 · 189c036 · 189c036
1 parent a49ee7e
commit 189c036
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/...book/src/migrations/update-14-0-0/migrate-defaults-5-to-6/migrate-defaults-5-to-6.spec.ts b/...book/src/migrations/update-14-0-0/migrate-defaults-5-to-6/migrate-defaults-5-to-6.spec.ts
@@ -22,6 +22,7 @@ describe('migrate-defaults-5-to-6 Generator', () => {
           '@nrwl/workspace': '10.4.0',
           '@storybook/addon-knobs': '^5.3.8',
           '@storybook/angular': '^5.3.8',
+          '@storybook/addon-notes': '5.3.21',
         },
       };
     });
@@ -60,17 +61,19 @@ describe('migrate-defaults-5-to-6 Generator', () => {
     });
   });
 
-  it('should update Storybook packages to latest version', async () => {
+  it('should update Storybook packages to latest version and ignore the ones to be ignored', async () => {
     migrateDefaultsGenerator(appTree);
 
     const packageJson = readJson(appTree, 'package.json');
-    // general deps
     expect(packageJson.devDependencies['@storybook/angular']).toEqual(
       storybookVersion
     );
     expect(packageJson.devDependencies['@storybook/addon-knobs']).toEqual(
       storybookVersion
     );
+    expect(packageJson.devDependencies['@storybook/addon-notes']).toEqual(
+      '5.3.21'
+    );
   });
 
   it('should update root config to version 6', async () => {

diff --git a/...storybook/src/migrations/update-14-0-0/migrate-defaults-5-to-6/migrate-defaults-5-to-6.ts b/...storybook/src/migrations/update-14-0-0/migrate-defaults-5-to-6/migrate-defaults-5-to-6.ts
@@ -85,6 +85,7 @@ function maybeUpdateVersion(tree: Tree): GeneratorCallback {
       '@storybook/testing-react',
       '@storybook/testing-vue',
       '@storybook/testing-vue3',
+      '@storybook/addon-notes',
     ];
 
     json.dependencies = json.dependencies || {};